Skip to content

Conversation

@kojiishi
Copy link
Contributor

To address the risk mentioned at #8292, this change allows UA to not to trim when there's not enough blank.

@kojiishi kojiishi marked this pull request as ready for review August 23, 2023 04:35
@kojiishi kojiishi requested a review from fantasai August 23, 2023 04:35
@kojiishi
Copy link
Contributor Author

Hey @fantasai, I heard from @chrishtr that you agree UA may not trim when doing so can cause excessive kerning. Can you review this change and see if this describes it?

@kojiishi kojiishi force-pushed the text-spacing-trim-give-up branch from 376f667 to a7c08a8 Compare September 1, 2023 06:59
@kojiishi
Copy link
Contributor Author

kojiishi commented Sep 1, 2023

Reworded a bit, hope this is better English ;-)


Some fonts have fullwidth punctuation characters
whose blank are too small to trim (kern.)
UA may not trim (kern)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UA may not trim (kern)
UA may choose not to trim (kern)

Otherwise "may not" is ambiguous, and could be seen as meaning the same as "must not"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for the review.

@kojiishi kojiishi merged commit 5159802 into w3c:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants